Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python version 3.7 to unblock tests #206

Closed
VladimirFokow opened this issue Feb 4, 2024 · 1 comment · Fixed by #207
Closed

Remove Python version 3.7 to unblock tests #206

VladimirFokow opened this issue Feb 4, 2024 · 1 comment · Fixed by #207

Comments

@VladimirFokow
Copy link
Contributor

VladimirFokow commented Feb 4, 2024

Currently, Python 3.7 in tests blocks some tests, so no pull requests are possible.

  • Python v.3.7 has reached its end-of-life, and v.3.8 will in 2024. Does this repo have to still support these versions?

  • Dropping support for them can ease the burden on maintainers: the deprecated dependencies currently block the tests for this repo - thus no pull requests are possible.

  • Plus, the newer Python versions can be supported here (until 3.12).

For example, numpy supports only Python 3.9+ as of 1.26.0 .

Which Python version should be the min. supported here: 3.8 or 3.9?

@VladimirFokow VladimirFokow changed the title Drop support for older Python versions Update the supported Python versions Feb 4, 2024
This was referenced Feb 4, 2024
@pfmoore
Copy link
Member

pfmoore commented Feb 4, 2024

This repo shouldn't be using anything version-specific as it's intended just as an example. I don't see any objection to updating the Python requirement to 3.8, but I'm -1 on trying to track supported Python versions as that's just ongoing maintenance work (and we don't actually "support" any particular Python versions, so it's not even accurate in any practical sense).

@VladimirFokow VladimirFokow changed the title Update the supported Python versions Remove Python version 3.7 to unblock tests Feb 4, 2024
@di di closed this as completed in #207 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants