Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reStructuredText header issue #144

Closed
dgasaway opened this issue Mar 19, 2018 · 9 comments
Closed

reStructuredText header issue #144

dgasaway opened this issue Mar 19, 2018 · 9 comments

Comments

@dgasaway
Copy link

I was testing a new project (new to PyPI) by uploading to TestPyPI. I have a README.rst file that is read into long_description. The README looked fine in bitbucket, passed readme_renderer and rst-lint, but kept failing to render formatted in the project description on TestPyPI. After tinkering for hours, I chopped up the file and kept adding more pieces until the failure came back, and it came down to a header that looked like this...

From Source
-----------

And then I noticed that in the (unformatted) project description on TestPyPI, it would strangely render with a greater than symbol in front...

>From Source
-----------

I made sure there were no special characters in that position in the file. Deleted everything between this and the text before it. Looked good. Eventually, I just changed the header, and the problem went away.

@brainwane
Copy link
Contributor

Hi, @dgasaway -- thanks for reporting this problem. Could you point us to the Test PyPI project that had this problem, and show us the README.rst file and the setup.py file? You can add a .txt file extension and attach those files directly to this issue.

@dgasaway
Copy link
Author

Hi. The project is here, but note that I've since had it corrected. It looks like that last one that showed the issue was 1.0.22. You can find the README.rst here. Although I didn't keep the readme for all the uploads to TestPyPI, the final commit shows the changes that fixed it. One of the many TestPyPI uploads probably matches that earlier revision, but I'm not sure which one.

@dgasaway
Copy link
Author

Sorry, I forgot to link to the setup.py. Thanks.

@brainwane
Copy link
Contributor

@dgasaway Hi - we've now made a number of improvements to Warehouse's README rendering. Could you upgrade your packaging and distribution toolchain -- setuptools and readme_renderer in particular -- and then let us know whether a similar incongruency shows up for you when the first couple lines of README.rst are

From Source
-----------

?

@di di transferred this issue from pypi/warehouse Nov 27, 2018
@jamadden
Copy link
Member

This reminds me of
pypa/wheel#178

@di
Copy link
Member

di commented Nov 27, 2018

Sounds similar. Perhaps we need to fix this farther upstream then, rather than in readme_renderer.

@merwok
Copy link

merwok commented Jan 11, 2019

This might be an email parameter issue from deep down in docutils :(

@dgasaway
Copy link
Author

If you're still looking for feedback from me (sorry), I tried it again with a new project I was working on today. Did not have a problem.

@brainwane
Copy link
Contributor

Since you could not reproduce the problem, I am going to close this, @dgasaway -- thank you for the report, and glad it's resolved!

Other people in the future should feel free to re-open this if the problem recurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants