Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message says to install readme_render[md] but cmarkgfm must be installed #133

Closed
kpinc opened this issue Oct 25, 2018 · 4 comments
Closed
Assignees
Labels

Comments

@kpinc
Copy link

kpinc commented Oct 25, 2018

This is something of an FYI because I'm not clear on what is really supposed to happen.

I tried running "twine check" and got a message that the README.rst could not be checked and that 'readme_render[md]' needed to be installed. But it seems that what needs to be installed is cmarkgfm.

The message is coming from readme_renderer. (Seemingly markdown.py line 28.)

FWIW, setup.py does not install_requires cmarkgfm either.

Thanks for listening.

@di
Copy link
Member

di commented Oct 25, 2018

Thanks @kpinc, I think I know what's happening here. The warning can be ignored.

@kpinc
Copy link
Author

kpinc commented Oct 25, 2018 via email

@mmerickel
Copy link

Note also that it's readme_renderer[md], not readme_render[md].

I also opened pypa/twine#420 related to its misuse of the new optional support for markdown in readme_renderer.

@di
Copy link
Member

di commented Oct 28, 2018

We'll fix this in twine with pypa/twine#421.

@di di closed this as completed Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants