Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipx install --editable fails during package determination #322

Closed
itsayellow opened this issue Jan 7, 2020 · 1 comment
Closed

pipx install --editable fails during package determination #322

itsayellow opened this issue Jan 7, 2020 · 1 comment

Comments

@itsayellow
Copy link
Contributor

itsayellow commented Jan 7, 2020

Describe the bug
Regression from #302. I think significant.

Background: pip install --editable needs either a local directory or VCS spec right after the --editable switch.

The #302 code added --no-dependencies after all pip arguments when determining the package name. In editable pipx installs, this has the effect of putting --no-dependencies between --editable and the package specification in the pip install arguments, which is illegal for pip, causing package determination to fail.

In addition, main.py code puts pip_args after --editable which would cause the same bug if both --editable and --pip_args are used.

How to reproduce

carvel:pipx pipx install --verbose -e git+https://github.com/itsayellow/datadiary
pipx > (run_subprocess:108): running /usr/local/opt/python/bin/python3.7 -m venv --without-pip /var/folders/5n/rx81rh0d35nbq92pjf3jpl2r0000gn/T/tmpu4hpo780
pipx > (run_subprocess:108): running /var/folders/5n/rx81rh0d35nbq92pjf3jpl2r0000gn/T/tmpu4hpo780/bin/python --version
pipx > (run_subprocess:108): running /var/folders/5n/rx81rh0d35nbq92pjf3jpl2r0000gn/T/tmpu4hpo780/bin/python -m pip list --format=json
pipx > (run_subprocess:108): running /var/folders/5n/rx81rh0d35nbq92pjf3jpl2r0000gn/T/tmpu4hpo780/bin/python -m pip install --editable --no-dependencies git+https://github.com/itsayellow/datadiary
ERROR: --no-dependencies is not a valid editable requirement. It should either be a path to a local project or a VCS URL (beginning with svn+, git+, hg+, or bzr+).
pipx > (install_package_no_deps:222): '/var/folders/5n/rx81rh0d35nbq92pjf3jpl2r0000gn/T/tmpu4hpo780/bin/python -m pip install --editable --no-dependencies git+https://github.com/itsayellow/datadiary' failed
Cannot determine package name from spec 'git+https://github.com/itsayellow/datadiary'. Check package spec for errors.
carvel:pipx 

Expected behavior

Package should have been installed normally

@itsayellow
Copy link
Contributor Author

Fixed by #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant