You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Regression from #302. I think significant.
Background: pip install --editable needs either a local directory or VCS spec right after the --editable switch.
The #302 code added --no-dependencies after all pip arguments when determining the package name. In editable pipx installs, this has the effect of putting --no-dependencies between --editable and the package specification in the pip install arguments, which is illegal for pip, causing package determination to fail.
In addition, main.py code puts pip_args after --editable which would cause the same bug if both --editable and --pip_args are used.
How to reproduce
carvel:pipx pipx install --verbose -e git+https://github.com/itsayellow/datadiary
pipx > (run_subprocess:108): running /usr/local/opt/python/bin/python3.7 -m venv --without-pip /var/folders/5n/rx81rh0d35nbq92pjf3jpl2r0000gn/T/tmpu4hpo780
pipx > (run_subprocess:108): running /var/folders/5n/rx81rh0d35nbq92pjf3jpl2r0000gn/T/tmpu4hpo780/bin/python --version
pipx > (run_subprocess:108): running /var/folders/5n/rx81rh0d35nbq92pjf3jpl2r0000gn/T/tmpu4hpo780/bin/python -m pip list --format=json
pipx > (run_subprocess:108): running /var/folders/5n/rx81rh0d35nbq92pjf3jpl2r0000gn/T/tmpu4hpo780/bin/python -m pip install --editable --no-dependencies git+https://github.com/itsayellow/datadiary
ERROR: --no-dependencies is not a valid editable requirement. It should either be a path to a local project or a VCS URL (beginning with svn+, git+, hg+, or bzr+).
pipx > (install_package_no_deps:222): '/var/folders/5n/rx81rh0d35nbq92pjf3jpl2r0000gn/T/tmpu4hpo780/bin/python -m pip install --editable --no-dependencies git+https://github.com/itsayellow/datadiary' failed
Cannot determine package name from spec 'git+https://github.com/itsayellow/datadiary'. Check package spec for errors.
carvel:pipx
Expected behavior
Package should have been installed normally
The text was updated successfully, but these errors were encountered:
Describe the bug
Regression from #302. I think significant.
Background:
pip install --editable
needs either a local directory or VCS spec right after the--editable
switch.The #302 code added
--no-dependencies
after all pip arguments when determining the package name. In editable pipx installs, this has the effect of putting--no-dependencies
between--editable
and the package specification in thepip install
arguments, which is illegal for pip, causing package determination to fail.In addition,
main.py
code putspip_args
after--editable
which would cause the same bug if both--editable
and--pip_args
are used.How to reproduce
Expected behavior
Package should have been installed normally
The text was updated successfully, but these errors were encountered: