-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra space in requirements generation #5506
Comments
Besides the optics of it, how is it a regression? pip still works with an extra space. |
yes, pip works, but projects end up trashing their git diffs with unrelated changes. |
Well, I am sorry for the inconvenience. But this is just a one time issue. Once you merge the changes, the is no longer an issue. There is also the possibility to use: |
Have to disagree about the one-time issue . It is not one-time issue . It's actually never-ending issue because different developers and dependabot modify the file . In fact , dependabot still struggles to deplot previous python_version / python_full_version flip flop fix :
and it's because pipenv dropped python 3.6 support in version where the fix is . aside : why the formatting change ? this is not going to be "fixed" ? why is the extra space better ? seems unnatural to me like putting space before dots and commas in natural language :
|
The extra space was added with the following commit: sarugaku/requirementslib@422cdae I am not sure that this is going to be fixed soon. I understand that this can cause a lot of changes in other projects, |
Ah right -- we had issues with pyparsing upgrade path which lead to this change. |
could someone with a knowledge provide reproducer for pyparsing developer: |
@glensc I tried to revert the change to the space in requirementslib, but ran into the issues with hypothesis tests failing again, and I suspect that is what lead to the space in the first place. It was only brought about when we upgraded |
This seems fixed now. We saw the opposite in recent builds, where the space differed.
|
This has been solved when we dropped requirementslib in recent release. |
Issue description
The command:
generates extra space before
;
when the attributes is set:First know to exist with
2022.11.23
version already:Expected result
do not change formatting; keep the space removed before
;
Actual result
When possible, provide the verbose output (
--verbose
), especially for locking and dependencies resolving issues.Steps to replicate
Provide the steps to replicate (which usually at least includes the commands and the Pipfile).
$ pipenv --support
Pipenv version:
'2022.11.25'
OS Name:
'posix'
User pip version:
'22.3'
user Python installations found:
3.10.8
:/usr/local/bin/python3
PEP 508 Information:
System environment variables:
SHELL
Pipenv–specific environment variables:
PIPENV_VERBOSITY
:-1
Debug–specific environment variables:
SHELL
:/usr/local/bin/bash
EDITOR
:/usr/local/bin/nvim
LANG
:en_US.UTF-8
Contents of
Pipfile
:Contents of
Pipfile.lock
:The text was updated successfully, but these errors were encountered: