Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Populate python_full_version instead of python_version in Pipfile when full python version is specified in "--python" arg #5345

Closed
internetofjames opened this issue Sep 9, 2022 · 2 comments
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. hacktoberfest Type: Enhancement 💡 This is a feature or enhancement request.

Comments

@internetofjames
Copy link

I verified that I am using the latest version of pipenv at the time of writing (2022.9.8).

Is your feature request related to a problem? Please describe.

Not related to a problem, just observed a behavior I find odd given current functionality of pipenv. When creating a virtual environment, specifying a full python version (e.g., pipenv install --python 3.10.4) generates a Pipfile with python_version = "3.10". Given that pipenv supports a python_full_version key in the [requires] table, it seems odd to me that it doesn't use the full version field when a full python version is specified. Instead, it only uses the python_version field and specifies the feature release (e.g., 3.10).

Describe the solution you'd like

When using a full python version qualifier in the pipenv install command (e.g., pipenv install --python 3.10.4), the resulting Pipfile will use the python_full_version field instead:

[requires]
python_full_version = "3.10.4"

If the full version is not specified, the current expected behavior should apply:

[requires]
python_version = "3.10"

Describe alternatives you've considered

An obvious workaround is to manually fill out the field, but if others agree with me, I believe this behavior should happen automatically.

@matteius matteius added Type: Enhancement 💡 This is a feature or enhancement request. hacktoberfest Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. labels Sep 11, 2022
@jerempy
Copy link
Contributor

jerempy commented Sep 30, 2022

I'd like to take a shot on this one

@dojutsu-user
Copy link
Contributor

@matteius I believe this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. hacktoberfest Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

No branches or pull requests

4 participants