Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the dot env earlier #5334

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Load the dot env earlier #5334

merged 3 commits into from
Sep 7, 2022

Conversation

matteius
Copy link
Member

@matteius matteius commented Sep 7, 2022

Load the dot env earlier so that PIPENV_CUSTOM_VENV_NAME is more useful across projects.

The problem is if you put the variable in your dot env it won't be applied in time for virtualenv creation/activation.

@matteius matteius requested a review from oz123 September 7, 2022 10:29
@oz123
Copy link
Contributor

oz123 commented Sep 7, 2022

I am going to wait with merging this branch until we merge #5331

@oz123 oz123 merged commit f6ef1d3 into main Sep 7, 2022
@oz123 oz123 deleted the earlier-dot-env-load branch September 7, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants