Revise other spots that did not use the internal pip vendoring #5229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Some of the other commands in core rely on the system installed pip, which has proven problematic for some issue reports in the past. In PR we made great strides to using the internal vendored pip version and we dropped pip from being an installed requirement: #5199
This PR addresses other found spots in core.py that were using the user or system installed version of pip. Fortunately in the latest pip we vendored in they revised the utility
_get_runnable_pipsuch that it no longer generates a zip file, and it is the logical point for getting the modulepipenv.patched.pipas a runnable python command.It took me a few tries to arrive at this solution.