Use COMSPEC for shell detection fallback #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subshell logic now considers: * PIPENV_SHELL * Auto detection * SHELL (should very likely work for POSIX) * PYENV_SHELL * COMSPEC (should always work for Windows)
|
Seems good, there was no alternative for far manager or whatever that was? |
|
Far Manager can be detected, but I don’t know it well enough and don’t know if it is even a good idea to spawn it (it’s more like a CLI file manager than a shell, complete with menus and things, similar to old DOS applications). This looks like a reasonable thing to do anyway (considering we already detect |
uranusjr
added
the
PR: awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subshell logic now considers:
This should be able to close sarugaku/shellingham#9 in the sense of not raising an exception.