Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-vendor Pew #2521

Merged
merged 3 commits into from
Jul 5, 2018
Merged

Un-vendor Pew #2521

merged 3 commits into from
Jul 5, 2018

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Jul 5, 2018

I believe we have removed all Pew usages in the code base.

  • pewtwo entry point is deleted.
  • Removed a related test. It was already skipped.
  • Module pipenv.pew is removed.
  • Vendored pipenv.vendor.pew is removed.
  • Removed Pew from vendoring scripts.
  • Removed patches for Pew.
  • Comments and documentation is checked to rewrite Pew mentions to relevant virtualenv wording.

@techalchemy
Copy link
Member

Does this cover project creation?

@techalchemy
Copy link
Member

If this passes and covers project creation I’m good with it.

@techalchemy
Copy link
Member

I.e pew new --project

@uranusjr
Copy link
Member Author

uranusjr commented Jul 5, 2018

Yes it does!

# Associate project directory with the environment.
# This mimics Pew's "setproject".
project_file_name = os.path.join(project.virtualenv_location, '.project')
with open(project_file_name, 'w') as f:
    f.write(fs_str(project.project_directory))

pew new --project == pew new + pew setproject.

@uranusjr
Copy link
Member Author

uranusjr commented Jul 5, 2018

p.s. We have test for project creation.

@uranusjr uranusjr merged commit ef6e667 into master Jul 5, 2018
@uranusjr uranusjr deleted the purge-pew branch July 5, 2018 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants