Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add downloaded/local archive path to InstallRequirement #7483

Merged
merged 4 commits into from
Dec 15, 2019
Merged

Add downloaded/local archive path to InstallRequirement #7483

merged 4 commits into from
Dec 15, 2019

Commits on Dec 14, 2019

  1. Add function to install directly from wheel files 

    This will help us avoid some complicated directory-changing logic in
WheelBuilder.
    @chrahunt
    chrahunt committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    3f912ad View commit details
    Browse the repository at this point in the history

  2. Switch to install_wheel in unit tests 

    Since it tests install_unpacked_wheel, the coverage should be the same.
    @chrahunt
    chrahunt committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    c565d7a View commit details
    Browse the repository at this point in the history

  3. Keep path to downloaded archive on InstallRequirement 

    Now we'll be able to transition other parts of the code to use
pre-existing archives directly instead of relying on unpacked sources.
    @chrahunt
    chrahunt committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    327c295 View commit details
    Browse the repository at this point in the history

  4. Switch to install_wheel in InstallRequirement 

    This removes one of usages of the overloaded `source_dir` member.

We know the local_file_path must be set at this point because it is set
in the only 3 places that wheels are added to InstallRequirement.
    @chrahunt
    chrahunt committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    11472e1 View commit details
    Browse the repository at this point in the history