Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up wheel.move_wheel_files #7176

Merged
merged 4 commits into from
Oct 20, 2019
Merged

Clean up wheel.move_wheel_files #7176

merged 4 commits into from
Oct 20, 2019

Commits on Oct 12, 2019

  1. Rename wheel install function

    @chrahunt
    chrahunt committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    578de7d View commit details
    Browse the repository at this point in the history

  2. Pass scheme to install_unpacked_wheel 

    This reduces the number of required arguments and helps establish a
convention for install_* functions, which should take a scheme instead
of the individual components.
    @chrahunt
    chrahunt committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    4682f3c View commit details
    Browse the repository at this point in the history

  3. Don't pass InstallRequirement to install_unpacked_wheel 

    We are only using this value for logging. Passing a string reduces
coupling between InstallRequirement and this function.
    @chrahunt
    chrahunt committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    39572dd View commit details
    Browse the repository at this point in the history

  4. Cleanup arguments, add docstring

    @chrahunt
    chrahunt committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    913f856 View commit details
    Browse the repository at this point in the history