Fix tests broken by Setuptools 69.0.3 which now preserves underscores in egg_info #12458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2024
sbidoul
reviewed
Jan 14, 2024
| @@ -119,7 +119,7 @@ def test_check_complicated_name_missing(script: PipTestEnvironment) -> None: | |||
|
|
|||
| # Without dependency | |||
| result = script.pip("install", "--no-index", package_a_path, "--no-deps") | |||
| assert "Successfully installed package-A-1.0" in result.stdout, str(result) | |||
| assert "Successfully installed package_A-1.0" in result.stdout, str(result) | |||
There was a problem hiding this comment.
maybe we should do a regex match so the pip test suite is not dependent on setuptools>=69 ?
There was a problem hiding this comment.
Haha, I totally forgot about that. I'm glad you picked this up. Thanks! 🙂
sbidoul
added
the
skip news
|
I think I found a reasonable way to fix the rest of the failures. If you don't mind I'll cherry-pick your commit here and continue. |
|
See linked PR which supersedes this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this works...
Some tests are still broken due to pypa/setuptools#4167.