Test suite support for Python 3.12 #12127
Conversation
uranusjr
added
the
skip news
uranusjr
force-pushed
the
no-setuptools-in-tests
branch
from
0b63f57
to
657678e
Compare
uranusjr
force-pushed
the
no-setuptools-in-tests
branch
2 times, most recently
from
fb41374
to
43d0fe9
Compare
uranusjr
force-pushed
the
no-setuptools-in-tests
branch
from
43d0fe9
to
e29dc1c
Compare
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: ${{ matrix.python }} | ||
| python-version: ${{ matrix.python.full || matrix.python }} |
There was a problem hiding this comment.
you can use allow-prereleases: true if you don't care about the specific beta version to test.
c.f. https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#allow-pre-releases
There was a problem hiding this comment.
| python-version: ${{ matrix.python.full || matrix.python }} | |
| python-version: ${{ matrix.python }}-dev |
This will gracefully move to using stable releases, once they are out.
Use -dev instead of a patch number (e.g., 3.12-dev) to install the latest patch version release for a given minor version, alpha and beta releases included.
There was a problem hiding this comment.
Both these solutions would cause prereleases for other versions to be picked up. I’m not sure I’m on board with that. I changed to full key to use -dev instead of -beta.3.
There was a problem hiding this comment.
Both these solutions would cause prereleases for other versions to be picked up.
They won't have any though?
There was a problem hiding this comment.
Will they not? I am not familiar with how GitHub publishes versions, but Python bug fixes do have prereleases officially.
|
Quick note - please avoid merging this until we know that we don't need a bugfix for 23.2 (see my comments on #12105). At which point, the debate about pre-release versions of 3.12 may no longer be relevant... |
Co-authored-by: Pradyun Gedam <[email protected]>
RC releases are still pre-releases! :) |
|
Actually, 3.12 final is due 02/10/2023, which is a bit unfortunate as we're going to be releasing 23.3 in October. Not much we can do about it, though. It does mean that maybe testing with the 3.12 RCs is more important than I'd assumed. So ignore my previous comment. |
|
Reminds me again there’s a discussion on shifting pip’s schedule one or two months to match CPython’s (relatively new) annual schedule |
This makes the test suite run on 3.12. Also fix #12121 since the same fixes in noxfile apply for virtualenv configured to not populate setuptools.