Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax PyPy compatibility location warning #9845

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Relax PyPy compatibility location warning #9845

merged 1 commit into from
Jul 9, 2021

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr added this to the 21.1 milestone Apr 25, 2021
@uranusjr uranusjr force-pushed the sysconfig-quelch-pypy-warning branch from 47c9404 to cf7cce7 Compare April 25, 2021 09:13
@uranusjr uranusjr requested a review from pradyunsg April 25, 2021 09:13
@sbidoul sbidoul modified the milestones: 21.1, 21.1.1 Apr 25, 2021
@pradyunsg pradyunsg mentioned this pull request Apr 25, 2021
Closed
@uranusjr uranusjr mentioned this pull request Apr 26, 2021
Closed
@sbidoul sbidoul removed this from the 21.1.1 milestone Apr 29, 2021
@sbidoul
Copy link
Member

sbidoul commented Apr 29, 2021

I removed from the 21.1.1 milestone.

@mattip
Copy link
Contributor

mattip commented Apr 30, 2021

LGTM

@uranusjr
Copy link
Member Author

Waiting for the 21.1.1 release before merging this.

@stonebig stonebig mentioned this pull request May 2, 2021
Closed
6 tasks
@stonebig
Copy link
Contributor

stonebig commented May 2, 2021

Sorry, I didn't follow-up. Why did you remove it from 21.1.1 ?

@pradyunsg
Copy link
Member

We relaxed the warning entirely, and wanted to expidite releasing that; since... uhm... our issue tracker was being DDOS'ed. 😅

@uranusjr
Copy link
Member Author

uranusjr commented May 6, 2021

I think this is good to merge? (Doesn’t really affect much now the warning is not visible by default anymore.)

@uranusjr uranusjr added this to the 21.2 milestone Jul 9, 2021
@uranusjr uranusjr merged commit 7cae5f2 into pypa:main Jul 9, 2021
@uranusjr uranusjr deleted the sysconfig-quelch-pypy-warning branch July 9, 2021 04:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.2
Development

Successfully merging this pull request may close these issues.
5 participants
@uranusjr @sbidoul @mattip @stonebig @pradyunsg