-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate build dependencies when using --no-build-isolation
#9794
Comments
A sanity check to make sure the user actually sets up the environment correctly makes sense to me. |
@mariocj89 and I are interested in helping out with this, |
@uranusjr @pradyunsg would you be able to please give a few pointers on where I should start looking in the code and what this change is going to look like? |
https://github.com/pypa/pip/blob/main/src/pip/_internal/operations/build/wheel.py and https://github.com/pypa/pip/blob/main/src/pip/_internal/operations/build/metadata.py -- that's where you wanna look for PEP 517 build logic. If you wanna have a longer chat/discussion about this code, ping me sometime during a work day. :) |
The change needed here is calling I'm pretty sure the things to figure out here are:
|
What's the problem this feature will solve?
Prevent builds from running when all required build dependencies are not present.
Describe the solution you'd like
pip
fails to build with a descriptive message when a build dependency is missing, providing a nicer user experience (IMHO).Alternative Solutions
Additional context
I see the pip docs on
--no-build-isolation
state "Build dependencies specified by PEP 518 must be already installed if this option is used.". I was wondering whether pip would like to mimic the behaviour thatpython-build
has on--no-isolation
(Fail nicely if build dependencies are not present) and if so I'm happy to try and push a patch.Related: #6718
The text was updated successfully, but these errors were encountered: