Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolver enters a loop where it collects multiple versions of internally hosted package #8863

Closed
ei8fdb opened this issue Sep 11, 2020 · 4 comments

Comments

@ei8fdb
Copy link
Contributor

ei8fdb commented Sep 11, 2020

I'm filing this on behalf of @ynouri who provided this via our feedback form for testing the new pip resolver.

pip version
pip 20.2

What did you want to do?
Install a corporate, internally built package that I suspect will dependencies conflicts

Additional information

  • Attempting to test the new resolver
  • Corporate setting
  • No access to PyPI.org, packages stored in internal corporate pip repo
    (JFrog Artifactory)
  • 2 index total: 1 in PIP_INDEX_URL, 1 in PIP_EXTRA_INDEX_URL
  • Installing a corporate, internally built package that I suspect will
    dependencies conflicts
  • Some of the dependencies of the package are specified with optional
    deps (e.g. corp_package_b[dev])

What happens
The resolver seems to enter in a loop where it collects multiple versions of my package: it displays several times "Collecting my_corporate_package". First version 0.10.1, then 0.9.3, then 0.9.2...I would expect it to send an error instead of looping

Similar to other open Github issues?
Yep - #8713, #8346.

Output

pip install my_corporate_package --use-feature=2020-resolver
Looking in indexes: https://my-corporate-pypi-repo-A/simple,
https://my-corporate-pypi-repo-B/simple/

Collecting my_corporate_package
  Downloading
https://my-corporate-pypi-repo-B/my_corporate_package/0.10.1/my_corporate_package-0.10.1-py2.py3-none-any.whl
(288 kB)
     |████████████████████████████████| 288 kB 6.3 MB/s
Requirement already satisfied: jinja2 in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (2.11.2)
Requirement already satisfied: pyyaml in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (5.3.1)
Requirement already satisfied: jsonschema in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (3.2.0)
Requirement already satisfied:
corp_package_c[hadoop,kerberos,logging,web]>=0.14.0 in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (0.15.5)
Collecting corp_package_b[dev]==0.1.5.dev190
  Using cached
https://my-corporate-pypi-repo-B/corp_package_b/0.1.5.dev190%2Bg6064efc/corp_package_b-0.1.5.dev190%2Bg6064efc-py2.py3-none-any.whl
(419 kB)
Requirement already satisfied: pyyaml in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (5.3.1)

Collecting my_corporate_package
  Using cached
https://my-corporate-pypi-repo-B/my_corporate_package/0.9.3/my_corporate_package-0.9.3-py2.py3-none-any.whl
(273 kB)
Requirement already satisfied: jinja2 in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (2.11.2)
Requirement already satisfied: pyyaml in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (5.3.1)
Requirement already satisfied: jsonschema in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (3.2.0)
Requirement already satisfied:
corp_package_c[hadoop,kerberos,logging,web]>=0.14.0 in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (0.15.5)
Requirement already satisfied: pyyaml in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (5.3.1)

Collecting my_corporate_package
  Downloading
https://my-corporate-pypi-repo-B/my_corporate_package/0.9.2/my_corporate_package-0.9.2-py2.py3-none-any.whl
(258 kB)
     |████████████████████████████████| 258 kB 3.1 MB/s
Requirement already satisfied: jinja2 in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (2.11.2)
Requirement already satisfied: pyyaml in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (5.3.1)
Requirement already satisfied: jsonschema in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (3.2.0)
Requirement already satisfied:
corp_package_c[hadoop,kerberos,logging,web]>=0.14.0 in
/home/ynouri/tmp/pip-resolver-test/lib/python3.6/site-packages (from
my_corporate_package) (0.15.5)"
@pfmoore
Copy link
Member

pfmoore commented Sep 11, 2020

What is the expected action on this? The posted output shows two iterations of the resolver trying different versions of the package, but the output is incomplete. Also, there's no way we can reproduce this issue with the information given. SO there's not much we can do to diagnose the issue or investigate further.

My guess (and it can't be much more than a guess based on the amount of information available) is that this is a duplicate of #8713.

@brainwane
Copy link
Contributor

@pradyunsg @uranusjr it would be great to get your opinion on this.

@pradyunsg
Copy link
Member

This is indeed a duplicate of #8713 IMO as well.

@brainwane
Copy link
Contributor

Thank you @ynouri for giving us your feedback! We will keep it in mind and proceed using #8713 as the issue we work on to make this better. Thanks for testing pip.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants