Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resolver: inconsistent output when using cached wheels #8860

Closed
pradyunsg opened this issue Sep 10, 2020 · 2 comments · Fixed by #8861
Closed

New Resolver: inconsistent output when using cached wheels #8860

pradyunsg opened this issue Sep 10, 2020 · 2 comments · Fixed by #8861
Labels
type: bug A confirmed bug or unintended behavior

Comments

@pradyunsg
Copy link
Member

#8066 added logic to make pip's new resolver perform lookups in the wheel cache. The way it's populating the requirement is, however, breaking the presentation logic in RequirementPreparer. This issue is present on 20.2 as well as master.

Processing /Users/pradyunsg/Library/Caches/pip/wheels/da/f1/6f/450a8e3042772f552f5316cfbd51552bb13995077e4502ba2f/rackspace_novaclient-2.1-py3-none-any.whl
Processing /Users/pradyunsg/Library/Caches/pip/wheels/45/42/fc/37502e2e6b8c5e745d2ec318c6d1ee9328ead3d704b5584797/ip_associations_python_novaclient_ext-0.2-py3-none-any.whl
Processing /Users/pradyunsg/Library/Caches/pip/wheels/b8/0c/c5/f4087714c89b18994a27c42c01bd9a8ce3bfcccf5d72ff978e/rackspace_auth_openstack-1.3-py3-none-any.whl
Processing /Users/pradyunsg/Library/Caches/pip/wheels/bc/eb/b2/2d27f5c5d3d8caecebbf87ccb272f60ee278d968c1c3a10c85/os_diskconfig_python_novaclient_ext-0.1.3-py3-none-any.whl
Processing /Users/pradyunsg/Library/Caches/pip/wheels/25/01/b7/d60cc1e3f2b4f9e5b359ce1b7fe03f65084020bfb0d4edcca2/os_networksv2_python_novaclient_ext-0.26-py3-none-any.whl
Processing /Users/pradyunsg/Library/Caches/pip/wheels/64/ce/0e/e407508c11ef0d63567a51a86302b44de81b78f602d7e8dc82/rax_scheduled_images_python_novaclient_ext-0.3.1-py3-none-any.whl
Processing /Users/pradyunsg/Library/Caches/pip/wheels/1d/b7/c2/8988a8a46e720cced366730c323604d1dba6644886f9a666aa/rax_default_network_flags_python_novaclient_ext-0.4.0-py3-none-any.whl
Processing /Users/pradyunsg/Library/Caches/pip/wheels/89/7c/51/371c863bd836d32c94f518678e612386ea757e4b195a080c78/os_virtual_interfacesv2_python_novaclient_ext-0.20-py3-none-any.whl
Collecting python-novaclient
  Using cached python_novaclient-17.2.1-py3-none-any.whl (319 kB)
Processing /Users/pradyunsg/Library/Caches/pip/wheels/48/6d/77/9517cb933af254f51a446f1a5ec9c2be3e45f17384940bce68/prettytable-0.7.2-py3-none-any.whl
Collecting iso8601>=0.1.11
  Using cached iso8601-0.1.12-py3-none-any.whl (12 kB)
Collecting stevedore>=2.0.1
  Using cached stevedore-3.2.1-py3-none-any.whl (42 kB)
Collecting oslo.i18n>=3.15.3
  Using cached oslo.i18n-5.0.0-py3-none-any.whl (46 kB)
Collecting six>=1.10.0
  Using cached six-1.15.0-py2.py3-none-any.whl (10 kB)
Collecting oslo.serialization!=2.19.1,>=2.18.0
  Using cached oslo.serialization-4.0.0-py3-none-any.whl (25 kB)
Collecting msgpack>=0.5.2
  Using cached msgpack-1.0.0-cp38-cp38-macosx_10_13_x86_64.whl (78 kB)
Collecting simplejson>=3.5.1
  Using cached simplejson-3.17.2-cp38-cp38-macosx_10_14_x86_64.whl (74 kB)
Collecting keystoneauth1>=3.5.0
  Using cached keystoneauth1-4.2.1-py3-none-any.whl (308 kB)

Notice the initial wheel files that are from the cache, printed in full. That should not happen.

Originally posted by @pradyunsg in #8066 (comment)

@pradyunsg pradyunsg added C: new resolver type: bug A confirmed bug or unintended behavior labels Sep 10, 2020
@uranusjr
Copy link
Member

uranusjr commented Sep 10, 2020

What should be printed instead? The file name, or the requirement line? I honestly almost never read pip’s output.

@pradyunsg
Copy link
Member Author

pradyunsg commented Sep 10, 2020

See the lines that follow, for how pip usually prints a requirement that's available in the cache. I think that line comes from the download logic though, and includes file size information.

PR upcoming for this and #8346.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants