Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore require-virtualenv in pip list #8603

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Ignore require-virtualenv in pip list #8603

merged 1 commit into from
Jul 29, 2020

Conversation

tekumara
Copy link
Contributor

Allow pip list to function when PIP_REQUIRE_VIRTUALENV=true. This allows inspection of system site-packages.

Fixes #8602

@McSinyx
Copy link
Contributor

McSinyx commented Jul 19, 2020

FYI you can also close and reopen the PR to trigger the CIs. The fails seems to have something to do with the status of PyPI XML-RPC API (relevant ticket: GH-5216).

@deveshks
Copy link
Contributor

Instead of making empty commits to retrigger build, you can rebase and squash your commits into one, or fake update the commit message git commit --amend --no-edit . Then force pushing to the branch should restart the build.

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me, but let’s rebase to get rid of the empty commits.

@tekumara
Copy link
Contributor Author

tekumara commented Jul 20, 2020

@deveshks @uranusjr thanks for the tip I've force pushed a single commit a couple of times as recommended and now the build finally passes! 🎉

Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradyunsg pradyunsg merged commit 31299ee into pypa:master Jul 29, 2020
@pradyunsg
Copy link
Member

Whoops! I didn't spot this in time for the 20.2 release. I'll include it in a bugfix if we make one. :)

@pradyunsg pradyunsg added this to the 20.2.1 milestone Aug 2, 2020
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Aug 4, 2020
bors bot referenced this pull request in duckinator/emanate Aug 5, 2020
158: Update pip to 20.2.1 r=duckinator a=pyup-bot


This PR updates [pip](https://pypi.org/project/pip) from **20.2** to **20.2.1**.



<details>
  <summary>Changelog</summary>
  
  
   ### 20.2.1
   ```
   ===================

Features
--------

- Ignore require-virtualenv in ``pip list`` (`8603 &lt;https://github.com/pypa/pip/issues/8603&gt;`_)

Bug Fixes
---------

- Correctly find already-installed distributions with dot (``.``) in the name
  and uninstall them when needed. (`8645 &lt;https://github.com/pypa/pip/issues/8645&gt;`_)
- Trace a better error message on installation failure due to invalid ``.data``
  files in wheels. (`8654 &lt;https://github.com/pypa/pip/issues/8654&gt;`_)
- Fix SVN version detection for alternative SVN distributions. (`8665 &lt;https://github.com/pypa/pip/issues/8665&gt;`_)
- New resolver: Correctly include the base package when specified with extras
  in ``--no-deps`` mode. (`8677 &lt;https://github.com/pypa/pip/issues/8677&gt;`_)
- Use UTF-8 to handle ZIP archive entries on Python 2 according to PEP 427, so
  non-ASCII paths can be resolved as expected. (`8684 &lt;https://github.com/pypa/pip/issues/8684&gt;`_)

Improved Documentation
----------------------

- Add details on old resolver deprecation and removal to migration documentation. (`8371 &lt;https://github.com/pypa/pip/issues/8371&gt;`_)
- Fix feature flag name in docs. (`8660 &lt;https://github.com/pypa/pip/issues/8660&gt;`_)
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/pip
  - Changelog: https://pyup.io/changelogs/pip/
  - Homepage: https://pip.pypa.io/
</details>



Co-authored-by: pyup-bot <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore require-virtualenv in pip list
6 participants