Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gating error messages based on date #8586

Open
pradyunsg opened this issue Jul 15, 2020 · 0 comments
Open

Gating error messages based on date #8586

pradyunsg opened this issue Jul 15, 2020 · 0 comments
Labels
state: awaiting PR Feature discussed, PR is needed state: needs discussion This needs some more discussion type: maintenance Related to Development and Maintenance Processes

Comments

@pradyunsg
Copy link
Member

Originally posted by @dstufft in #5216 (comment)

We could also bake some sort of time gating right into the message, like in the Python code check if the date is before some cut off date before showing the message.

In a recent discussion w/ @ei8fdb @nlhkabu et al, folks was expressed that this would be something really good to "formalize", so that it can be used in the future for communication around changes/user surveys.

@brainwane also suggested that it might be possible to combine/tie this with our deprecation policy -- but that's not something I'm fully clear on how she was thinking it could/would work.

If we want to formalize this, we could create something like our deprecated helper for deprecations. :)


We're definitely doing something like this for #5216 and my plan for now is to "just add the right words" to the error message (in other words, this isn't a blocker in any way).

@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Jul 15, 2020
@pradyunsg pradyunsg added state: needs discussion This needs some more discussion type: maintenance Related to Development and Maintenance Processes labels Jul 15, 2020
@triage-new-issues triage-new-issues bot removed S: needs triage Issues/PRs that need to be triaged labels Jul 15, 2020
@pradyunsg pradyunsg added state: awaiting PR Feature discussed, PR is needed good first issue A good item for first time contributors to work on labels Sep 2, 2021
@pradyunsg pradyunsg removed the good first issue A good item for first time contributors to work on label Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: awaiting PR Feature discussed, PR is needed state: needs discussion This needs some more discussion type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

No branches or pull requests

1 participant