Add format_command_args(). #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
type: enhancement
cjerdonek
force-pushed
the
add-format-command
branch
from
8453d62 to
1c144bb
Compare
cjerdonek
force-pushed
the
add-format-command
branch
from
1c144bb to
87f0539
Compare
pradyunsg
approved these changes
Feb 24, 2019
|
Super clean PR! I learnt stuff here @cjerdonek. :) |
|
Aw, thank you! 😊 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does mainly two things:
It refactors out from
call_subprocess()a simple helper function to format command arguments for display. I called this functionformat_command_args(). This lets us use this function in the recently created functionget_legacy_build_wheel_path(), which I have done in this PR (resulting in a nicer display for that function). Refactoring the function out also (1) makescall_subprocess()simpler, and (2) makes it easier to test the functionality (tests were also added).It simplifies the implementation using
shlex.quote()-- also making it copy-pasteable.The PR is broken up into separate commits, each of which does something different. For example, simplifying the implementation is done in its own commit.