AttributeError: Values instance has no attribute 'find_links'

[robgom]

Environment

• pip version: pip 10.0.1 from c:\python27\lib\site-packages\pip (python 2.7)
• Python version: 2.7.14
• OS: Windows 10

Description

$ pip config list --verbose
For variant 'global', will try loading 'C:\ProgramData\pip\pip.ini'
For variant 'user', will try loading 'C:\Users\<user>\pip\pip.ini'
For variant 'user', will try loading 'C:\Users\<user>\AppData\Roaming\pip\pip.ini'
global.cert='C:\\ProgramData\\pip\\ca-bundle.crt'
global.index-url='...........'
install.no-binary='.......'
There was an error checking the latest version of pip
Traceback (most recent call last):
  File "c:\python27\lib\site-packages\pip\_internal\utils\outdated.py", line 125, in pip_version_check
    find_links=options.find_links,
AttributeError: Values instance has no attribute 'find_links'

Expected behavior
No exception

How to Reproduce

1. Execute pip config --list --verbose

[rickyrockrat]

I can confirm on Linux also
pip -vvv config
Need an action (edit, get, list, set, unset) to perform.
There was an error checking the latest version of pip
Traceback (most recent call last):
File "/opt/our_custom_path/lib/python2.7/site-packages/pip/_internal/utils/outdated.py", line 125, in pip_version_check
find_links=options.find_links,
AttributeError: Values instance has no attribute 'find_links'
pip -V
pip 10.0.1 from /opt/our_custom_path/lib/python2.7/site-packages/pip (python 2.7)

[xavfernandez]

I confirm 👍
Thanks for the report.

[pradyunsg]

I just tried this on a fresh Ubuntu 14.04 system, I didn't get any errors.

Could someone explain how to reproduce this?

[xavfernandez]

There is something strange here:
I'm only getting the error with my system's pip (on archlinux) and not in a fresh venv, but the only diff between the two are in the "pip/_vendor" which is unlikely to explain the difference...

[xavfernandez]

Ok: in a fresh venv we are using a different file for pip-selfcheck.json (https://github.com/pypa/pip/blob/10.0.1/src/pip/_internal/utils/outdated.py#L26) and not the global one (https://github.com/pypa/pip/blob/10.0.1/src/pip/_internal/utils/outdated.py#L51).
@pradyunsg : removing the pip-selfcheck.json should trigger the issue

[pradyunsg]

@xavfernandez FWIW, we simplified the two file mechanism in #5419 -- that might make this harder to reproduce on master. Is this still an issue on master?

I've tried on a pyenv installed Python 3.7 on MacOS and it doesn't seem to be erroring for me, in a venv or outside of it. I have empty configuration files however.

Could you provide the exact config file contents that is causing this? :/

[xavfernandez]

@pradyunsg the issue still exists on master.

You don't need a config file, you only need to end up here: https://github.com/pypa/pip/blob/96f9fcc/src/pip/_internal/utils/outdated.py#L103 (so either an old date in selfcheck.json or no selfcheck.json at all).

The issue being that options won't contain a find_links key which is expected since this option is only present in index_group which in turn is only available in wheel, install, list and download commands.

Thus we get similar traceback for freeze:

$ pip freeze -v
Created temporary directory: /tmp/pip-ephem-wheel-cache-e138jnjj
There was an error checking the latest version of pip
Traceback (most recent call last):
  File "/home/xfernandez/.virtualenvs/tmp-475844793f0ebbc/lib/python3.6/site-packages/pip/_internal/utils/outdated.py", line 107, in pip_version_check
    index_urls=[options.index_url] + options.extra_index_urls,
AttributeError: 'Values' object has no attribute 'index_url'

and show:

$ pip show pip -v
Name: pip
Version: 18.0.dev0
Summary: The PyPA recommended tool for installing Python packages.
Home-page: https://pip.pypa.io/
Author: The pip developers
Author-email: [email protected]
License: MIT
Location: /home/xfernandez/.virtualenvs/tmp-475844793f0ebbc/lib/python3.6/site-packages
Requires: 
Required-by: 
Metadata-Version: 2.1
Installer: pip
Classifiers:
  Development Status :: 5 - Production/Stable
  Intended Audience :: Developers
  License :: OSI Approved :: MIT License
  Topic :: Software Development :: Build Tools
  Programming Language :: Python
  Programming Language :: Python :: 2
  Programming Language :: Python :: 2.7
  Programming Language :: Python :: 3
  Programming Language :: Python :: 3.4
  Programming Language :: Python :: 3.5
  Programming Language :: Python :: 3.6
  Programming Language :: Python :: Implementation :: CPython
  Programming Language :: Python :: Implementation :: PyPy
Entry-points:
  [console_scripts]
  pip = pip._internal:main
  pip3 = pip._internal:main
  pip3.6 = pip._internal:main
There was an error checking the latest version of pip
Traceback (most recent call last):
  File "/home/xfernandez/.virtualenvs/tmp-475844793f0ebbc/lib/python3.6/site-packages/pip/_internal/utils/outdated.py", line 106, in pip_version_check
    find_links=options.find_links,
AttributeError: 'Values' object has no attribute 'find_links'

Maybe we should restrict pip selfcheck to commands with index_group options available ?

[pradyunsg]

Ah. Right. So, that seems like an issue with the self check logic.

Your suggestion makes sense to me. It'll be an interesting task to implement it though. ;)

[techtonik]

The self-checking logic is strange.

1. It uses one global state file outside of virtualenv for caching pip version checks.
2. It uses PackageFinder component where it could just query some URL with latest tag.
3. It checks installed version instead of checking itself.

[techtonik]

Added request to PyPI to simplify lookups by using just a single request- pypi/warehouse#4663

[pradyunsg]

Reproduced this. Working on this.

[pradyunsg]

Your suggestion makes sense to me. It'll be an interesting task to implement it though. ;)

Turns out, a simple hasattr call was enough. :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.