Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support git refs in @ syntax #3876

Closed
zzzeek opened this issue Jul 26, 2016 · 1 comment · Fixed by #4429
Closed

support git refs in @ syntax #3876

zzzeek opened this issue Jul 26, 2016 · 1 comment · Fixed by #4429
Labels
auto-locked Outdated issues that have been locked by automation
Milestone

Comments

@zzzeek
Copy link

zzzeek commented Jul 26, 2016

We'd like to be able to put paths to gerrit reviews in requirements files.

Given a gerrit like https://review.openstack.org/#/c/345601/6, the path given for a git pull looks like:

git pull https://git.openstack.org/openstack/oslo.db refs/changes/01/345601/6

pip syntax we'd expect would be:

.venv/bin/pip install -e git+https://git.openstack.org/openstack/oslo.db@refs/changes/01/345601/6#egg=oslo.db

current output:


Obtaining oslo.db from git+https://git.openstack.org/openstack/oslo.db@refs/changes/01/345601/6#egg=oslo.db
  Cloning https://git.openstack.org/openstack/oslo.db (to refs/changes/01/345601/6) to ./.venv/src/oslo.db
  Could not find a tag or branch 'refs/changes/01/345601/6', assuming commit.
error: pathspec 'refs/changes/01/345601/6' did not match any file(s) known to git.
Command "git checkout -q refs/changes/01/345601/6" failed with error code 1 in /home/classic/.venv/src/oslo.db
@pradyunsg
Copy link
Member

pradyunsg commented Dec 21, 2016

@sshnaidm Please use Github reactions. They're meant for exactly this.

@xavfernandez xavfernandez added this to the 10.0 milestone Apr 8, 2017
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants