Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Github edit links are broken #2861

Closed
techtonik opened this issue Jun 2, 2015 · 7 comments
Closed

docs: Github edit links are broken #2861

techtonik opened this issue Jun 2, 2015 · 7 comments
Labels
auto-locked Outdated issues that have been locked by automation type: docs Documentation related

Comments

@techtonik
Copy link
Contributor

https://pip.pypa.io/en/stable/news.html
goes to
https://github.com/pypa/pip/blob/stable/docs/news.rst
which is 404.

@marscher
Copy link

marscher commented Nov 8, 2016

probably because it is a generated file...

@xavfernandez xavfernandez added the type: docs Documentation related label Nov 8, 2016
@xavfernandez
Copy link
Member

Currently the Github edit link points to https://github.com/pypa/pip/blob/28cc0b291db6ee5686010378edab60abf0067003/docs/index.rst where 28cc0b291db6ee5686010378edab60abf0067003 is the reference of the git tag object and not its related commit.

This comes from: readthedocs/readthedocs.org#1820

@marscher
Copy link

marscher commented Nov 9, 2016

Thanks for the link!

@dstufft
Copy link
Member

dstufft commented Mar 30, 2017

This is an issue with RTD and there's not much we can do about it here. When RTD fixes this it will be fixed for us automatically.

@dstufft dstufft closed this as completed Mar 30, 2017
@techtonik
Copy link
Contributor Author

But it is not fixed, the issue is still there. Why close it? It also gives an indication to RTD that their issue is still actual.

@pfmoore
Copy link
Member

pfmoore commented Apr 9, 2017

Because it's not a pip issue. If you want RTD to fix it, report it to them (or comment on an existing issue if there's one raised already).

@techtonik
Copy link
Contributor Author

It is done already - readthedocs/readthedocs.org#1820 (comment) - still the issue with edit links for pip is there. An alternative is to move from RTD, for example.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation type: docs Documentation related
Projects
None yet
Development

No branches or pull requests

5 participants