Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in pip's pinned preference on packages that have a requirement ==N.* #13030

Open
1 task done
notatallshaw opened this issue Oct 18, 2024 · 1 comment · May be fixed by #13017
Open
1 task done

Bug in pip's pinned preference on packages that have a requirement ==N.* #13030

notatallshaw opened this issue Oct 18, 2024 · 1 comment · May be fixed by #13017
Labels
type: bug A confirmed bug or unintended behavior

Comments

@notatallshaw
Copy link
Member

Description

The pip resolver prefers packages that are pinned, however it only checks the operator has the string == in it: https://github.com/pypa/pip/blob/24.2/src/pip/_internal/resolution/resolvelib/provider.py#L158

This does not imply a pinned package, as the requirement could be ==1.*, which is not pinned.

Expected behavior

Should consider the version part of the requirement when pinning a package.

pip version

24.2

Python version

Any

OS

Any

How to Reproduce

Install a package where a transative requirement has the form ==N[.M...].*

Output

N/A

Code of Conduct

@notatallshaw notatallshaw added type: bug A confirmed bug or unintended behavior S: needs triage Issues/PRs that need to be triaged and removed S: needs triage Issues/PRs that need to be triaged labels Oct 18, 2024
@notatallshaw
Copy link
Member Author

This is fixed as part of #13017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant