Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--proxy option requires scheme, does not work without it #10951

Merged
merged 2 commits into from
Mar 11, 2022
Merged

--proxy option requires scheme, does not work without it #10951

merged 2 commits into from
Mar 11, 2022

Conversation

gpchelkin
Copy link
Contributor

@gpchelkin gpchelkin commented Mar 9, 2022 •
edited
Loading

--proxy option requires scheme, does not work without it.

See also: 2b2ca40

Supersedes #10037

@gpchelkin gpchelkin marked this pull request as ready for review March 9, 2022 14:03
uranusjr
uranusjr approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC it does work without scheme in certain situations, but adding a scheme is best practice anyway, so let’s change the documentation.

@gpchelkin gpchelkin mentioned this pull request Mar 9, 2022
Closed
@pradyunsg pradyunsg merged commit 0561ab2 into pypa:main Mar 11, 2022
@pradyunsg
Copy link
Member

The CI failure is a flaky test, so that's fine. :)

@pradyunsg
Copy link
Member

Thanks @gpchelkin! ^>^

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpchelkin @pradyunsg @uranusjr