Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernise type annotations using FA rules from ruff #785

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

pradyunsg
Copy link
Member

Supercedes and closes #754

This also enables recursive type checks at the one location enabled by newer type checker versions.

@pradyunsg pradyunsg mentioned this pull request Mar 10, 2024
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Pradyun!

@pradyunsg pradyunsg enabled auto-merge (squash) March 10, 2024 23:32
This enforces the use of `from __future__ import annotations` on all
files that use objects from `typing` that have clearer syntax available
in newer typing  annotation syntax.
This makes use of more accurate type checking enabled by newer type
checker versions.
@pradyunsg pradyunsg force-pushed the modernise-annotations branch from 5ebe2ae to 4223a24 Compare March 10, 2024 23:33
@pradyunsg pradyunsg merged commit cc938f9 into pypa:main Mar 10, 2024
30 checks passed
kodiakhq bot referenced this pull request in cloudquery/plugin-sdk-python Jul 1, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [packaging](https://togithub.com/pypa/packaging) | minor | `==24.0` -> `==24.1` |

---

### Release Notes

<details>
<summary>pypa/packaging (packaging)</summary>

### [`v24.1`](https://togithub.com/pypa/packaging/releases/tag/24.1)

[Compare Source](https://togithub.com/pypa/packaging/compare/24.0...24.1)

#### What's Changed

-   pyupgrade/black/isort/flake8 → ruff by [@&#8203;DimitriPapadopoulos](https://togithub.com/DimitriPapadopoulos) in [https://github.com/pypa/packaging/pull/769](https://togithub.com/pypa/packaging/pull/769)
-   Add support for Python 3.13 and drop EOL 3.7 by [@&#8203;hugovk](https://togithub.com/hugovk) in [https://github.com/pypa/packaging/pull/783](https://togithub.com/pypa/packaging/pull/783)
-   Bump the github-actions group with 4 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/pypa/packaging/pull/782](https://togithub.com/pypa/packaging/pull/782)
-   Fix typo in `_parser` docstring by [@&#8203;pradyunsg](https://togithub.com/pradyunsg) in [https://github.com/pypa/packaging/pull/784](https://togithub.com/pypa/packaging/pull/784)
-   Modernise type annotations using FA rules from ruff by [@&#8203;pradyunsg](https://togithub.com/pradyunsg) in [https://github.com/pypa/packaging/pull/785](https://togithub.com/pypa/packaging/pull/785)
-   Document `markers.default_environment()` by [@&#8203;edgarrmondragon](https://togithub.com/edgarrmondragon) in [https://github.com/pypa/packaging/pull/753](https://togithub.com/pypa/packaging/pull/753)
-   Bump the github-actions group with 3 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/pypa/packaging/pull/789](https://togithub.com/pypa/packaging/pull/789)
-   Work around platform.python_version() returning non PEP 440 compliant version for non-tagged CPython builds by [@&#8203;sbidoul](https://togithub.com/sbidoul) in [https://github.com/pypa/packaging/pull/802](https://togithub.com/pypa/packaging/pull/802)

#### New Contributors

-   [@&#8203;dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/pypa/packaging/pull/782](https://togithub.com/pypa/packaging/pull/782)
-   [@&#8203;edgarrmondragon](https://togithub.com/edgarrmondragon) made their first contribution in [https://github.com/pypa/packaging/pull/753](https://togithub.com/pypa/packaging/pull/753)

**Full Changelog**: pypa/packaging@24.0...24.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMyIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhdXRvbWVyZ2UiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants