Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations to packaging.tags #189

Closed
cjerdonek opened this issue Aug 25, 2019 · 2 comments · Fixed by #200
Closed

Add type annotations to packaging.tags #189

cjerdonek opened this issue Aug 25, 2019 · 2 comments · Fixed by #200
Labels
enhancement

Comments

@cjerdonek
Copy link
Member

cjerdonek commented Aug 25, 2019 •
edited
Loading

pip's pep425tags module has type annotations, so it would be good for packaging.tags to have type annotations as well before switching pip away from pep425tags.

It looks like this would require adding a mypy CI check.
@cjerdonek cjerdonek mentioned this issue Aug 25, 2019
Closed
@brettcannon brettcannon mentioned this issue Aug 26, 2019
Closed
@pradyunsg
Copy link
Member

pradyunsg commented Aug 27, 2019 •
edited
Loading

@brettcannon I'm in for shipping with type annotations inline, for the entire codebase here.

@di
Copy link
Member

di commented Sep 10, 2019

I'm working on this.

@di di mentioned this issue Sep 14, 2019
Merged
@di di closed this as completed in #200 Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type annotations di/packaging
4 participants
@brettcannon @di @cjerdonek @pradyunsg