Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements lock to use twine v6 #308

Closed
ddelange opened this issue Dec 1, 2024 · 9 comments · Fixed by #309
Closed

Update requirements lock to use twine v6 #308

ddelange opened this issue Dec 1, 2024 · 9 comments · Fixed by #309

Comments

@ddelange
Copy link

ddelange commented Dec 1, 2024

Hi 👋

twine v6 was released, allowing metadata v2.4 via pypa/twine#1123. Could you update the lockfiles and cut a release?

@ddelange
Copy link
Author

ddelange commented Dec 1, 2024

cc @webknjaz @woodruffw :)

@woodruffw
Copy link
Member

I can send a PR for @webknjaz to review later today.

It's worth noting that release v6 doesn't have "full" support for metadata 2.4 quite yet; it just suppresses the outright failures that happened in earlier versions. But IMO that's an improvement in the status quo, versus having new builds fail entirely.

@woodruffw
Copy link
Member

#309 performs the bump. I'll send a separate bump PR when the (upcoming) twine release that handles 2.4 more thoroughly is ready.

@samuelcolvin
Copy link

Please please can we have a new release including this fix.

@ddelange
Copy link
Author

ddelange commented Dec 9, 2024

xref #313

@webknjaz
Copy link
Member

webknjaz commented Dec 9, 2024

Thanks for the nudges! I've started the required activities and the pessimistic ETA is an hour, but realistically it should be out much sooner.

@webknjaz
Copy link
Member

webknjaz commented Dec 9, 2024

UPD: I've pushed the tag 44 minutes ago so it's usable and people on release/v1 get it automatically already. Doing finishing touches in the change log, so it'll also show up as a GH Release (+ on the marketplace) soon.

@webknjaz
Copy link
Member

webknjaz commented Dec 9, 2024

@ddelange @samuelcolvin v1.12.3 is fully out: #314. Enjoy!

@davidhewitt
Copy link

Amazing, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants