Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature wish: Tolerate existing version in flit publish #678

Closed
bluenote10 opened this issue Mar 14, 2024 · 2 comments
Closed

Feature wish: Tolerate existing version in flit publish #678

bluenote10 opened this issue Mar 14, 2024 · 2 comments

Comments

@bluenote10
Copy link

I'm new to flit, so maybe I'm just missing something, but it would be nice to have an option to tolerate an existing published version on PyPI.

Motivation

I use this CI pattern with my other (non flit) Python packages: On a push to the main branch, the corresponding GitHub Action runs the PyPI upload with a skip_existing: true setting. This is pretty nice, because

  • it executes basically the entire build & upload procedure even in cases that don't need to actually publish a new version, maximizing the pipeline test coverage in these cases (i.e., if that pipeline succeeds I can have some confidence that really publishing a version would work as well if only the pure upload is skipped).
  • at the same time, it doesn't mark the publish pipeline as failed just because the version wasn't bumped and the remote version already exists, which is not really a pipeline error.

So far I haven't found how to replicate this mode with flit. Currently my publish pipeline fails with requests.exceptions.HTTPError: 400 Client Error: File already exists. when I haven't bumped the version.

I'm also not a big fan of the other common solution (#276 (comment)) of running the publish pipeline only when a tag was pushed, because maintaining git version tags violates the single-source-of-truth of the version information.

I'd be curious if there are other common solutions?

Possible solution

If not, it would be nice to have flit publish --skip-existing. The implementation could be e.g.:

  • simply make the File already exists response an accepted case (this would have the maximum coverage of the publish procedure).
  • pre-check if the version already exists and skip the actual upload attempt.
@5j9
Copy link

5j9 commented Jun 9, 2024 •
edited
Loading

In #142 it has been suggested to use twine for publishing the project.

In my case, publish attempts were failing with requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://upload.pypi.org/legacy/ . I tried everything, upgrading tools, resetting upload tokens, using a proxy server, etc. I had no clue that there was already a successful release uploaded. I finally tried twine in --verbose mode and it showed me the underlying error:

INFO     Response from https://upload.pypi.org/legacy/:
         400 Bad Request
INFO     <html>
          <head>
           <title>400 File already exists. See https://pypi.org/help/#file-name-reuse for more information.</title>
          </head>
          <body>
           <h1>400 File already exists. See https://pypi.org/help/#file-name-reuse for more information.</h1>
           The server could not comply with the request since it is either malformed or otherwise incorrect.<br/><br/>
         File already exists. See https://pypi.org/help/#file-name-reuse for more information.


          </body>
         </html>
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
         Bad Request

@bluenote10
Copy link
Author

Thanks for pointing to #142. It looks like this issue is actually a duplicate of it, so I would close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@5j9 @bluenote10