-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release? #247
Comments
1.3 is on PyPI now. Thanks, but I don't find updating the version number is a significant amount of the effort in creating a new release, and I don't like the notion of packages looking up their own metadata at import time in any case. |
Thank you so much!
Oh, why not? because there could be multiple versions of the same package installed? In any case, it’s the only way to do it with flit having no build step! |
For much the same reason that I don't like objects inspecting the stack to find out what their name is in some namespace; it feels inside-out. Especially for something that happens on import, I don't want the package poking around my filesystem trying to find its metadata, or running git in a subprocess. The problem it's solving also isn't something that bothers me much. Assembling a decent set of release notes takes much longer than changing a version number. I do find it slightly inconvenient at times that the version number has to be set in multiple places. You can see in the commit history that I initially forgot to change the version number to 1.3 for the docs, and had to make another commit to do that. But for this I prefer the kind of approach offered by bumpversion, where the extra complexity is in developer tools, not something that happens at runtime in the module. |
It’s true, however the state of the release notes on publication isn’t that important, since readthedocs/latest shows the release notes from the master branch. For my own projects, I usually prefer having bugfix releases out fast instead of waiting until I can take the time to update the release notes. Once I have the time, I go through the git history and retroactively compile the release notes. |
I like to do release notes when I'm making the release, because otherwise I'll probably never do them. 🙂 |
I don’t know why I manage to not procrastinate in that regard while procastinating is so many others, but somehow it comes easily to me. Maybe because I enjoy reading release notes for projects I’m excited about (including this one, thank you for it!)
Haha, that’s exactly what I wanted to avoid and why i wrote For my R stuff I also regularly forget recompiling the docs. If I can integrate things like that into the build system, I’m happy. Flit doesn’t have a customizable build step, so I went the metadata route. |
Thanks! 😃
I'm not too worried about forgetting to increment the version number at all - that's an intrinsic part of what I think of as 'making a release'. And if I don't do it, the upload will fail anyway. But I do sometimes have trouble remembering the different places it needs updating.
The idea is still under consideration (#119), but it's not a priority at the moment. Part of what's so nice about Flit is the simplicity of not having a build step. I did start a project called modeltee to automate release steps, as distinct from build steps. That includes things like tagging the release and publishing it to PyPI. I keep meaning to get back to working on it, to the point where I use it for projects like Flit. |
As soon as any kind of information is at two separate places in the same project, I consider that a bug in the tooling. |
I agree that it's good to have a 'single source of truth'. That's why Flit doesn't require the version number in the configuration. But I prefer a bit of duplication to some of the solutions to avoid it. |
Certainly. I think the my favourite solution would be
Using |
Hi! I have a few 3.5+ packages relying on flit and future-fstrings. Using the dev version of flit is a bit cumbersome.
PS: If you find it to annoying to make releases, I recommend transitioning flit to
get_version
. It makes a new release as easy asgit tag v1.2.3 && flit publish && git push --tags
The text was updated successfully, but these errors were encountered: