From 0618babf0c18fa909ae17a7f25e64c44a2760bbe Mon Sep 17 00:00:00 2001 From: doronz Date: Thu, 7 Dec 2023 08:21:42 +0200 Subject: [PATCH 1/3] doc: add clarification regarding linux docker environment --- docs/setup.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/setup.md b/docs/setup.md index cddf46a21..550015496 100644 --- a/docs/setup.md +++ b/docs/setup.md @@ -52,6 +52,7 @@ Install cibuildwheel and run a build like this: ``` You should see the builds taking place. You can experiment with options using environment variables or pyproject.toml. +Please take into account the build is performed on a wide variety of linux distros with different package managers. !!! tab "Environment variables" From f2dc466d03672f2ade347d15027f6ada931e3b86 Mon Sep 17 00:00:00 2001 From: doronz Date: Thu, 7 Dec 2023 08:22:31 +0200 Subject: [PATCH 2/3] doc: refactor `CIBW_BEFORE_ALL` examples to working versions --- docs/setup.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/setup.md b/docs/setup.md index 550015496..bdf9ff09d 100644 --- a/docs/setup.md +++ b/docs/setup.md @@ -62,7 +62,7 @@ Please take into account the build is performed on a wide variety of linux distr ```sh # run a command to set up the build system - export CIBW_BEFORE_ALL='apt install libpng-dev' + export CIBW_BEFORE_ALL='uname -a' cibuildwheel --platform linux ``` @@ -70,7 +70,7 @@ Please take into account the build is performed on a wide variety of linux distr > CMD (Windows) ```bat - set CIBW_BEFORE_ALL='apt install libpng-dev' + set CIBW_BEFORE_ALL='uname -a' cibuildwheel --platform linux ``` @@ -83,7 +83,7 @@ Please take into account the build is performed on a wide variety of linux distr ``` [tool.cibuildwheel] - before-all = "apt install libpng-dev" + before-all = "uname -a" ``` Then invoke cibuildwheel, like: From 2a83588552e256468770b630f6d7cc4e798a5d00 Mon Sep 17 00:00:00 2001 From: Joe Rickerby Date: Fri, 26 Jan 2024 18:48:10 +0000 Subject: [PATCH 3/3] Apply suggestions from code review --- docs/setup.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/setup.md b/docs/setup.md index bdf9ff09d..f5379ba3e 100644 --- a/docs/setup.md +++ b/docs/setup.md @@ -52,7 +52,6 @@ Install cibuildwheel and run a build like this: ``` You should see the builds taking place. You can experiment with options using environment variables or pyproject.toml. -Please take into account the build is performed on a wide variety of linux distros with different package managers. !!! tab "Environment variables"