-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: ensure console scripts are available on PATH during build #221
Conversation
Signed-off-by: Bernát Gábor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I just have some minor comments.
Signed-off-by: Bernát Gábor <[email protected]>
Signed-off-by: Bernát Gábor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this.
@FFY00 can we get this out the door? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😊
Considering this is a critical bugfix can we do a release with what we have (0.1.1?), thanks! |
Just a FYI, since we now have a changelog you can add an entry to |
We can have a new release sure, but because there were a few behavior changes I think it should be |
Sure, I generally reserve minor versions for feature additions, not bug fixes, but don't mind.
How do you determine relevance? This feels very subjective and open for debate. I'd suggest something more objective. |
I am generally inclined to also increment minor versions when there are behavior changes that might break stuff, which is the case with us now resolving dependencies recursively.
Yes, it's subjective. I am not very picky here. The goal is to try to make things easier for users, if that requires two more sentences exchanged between maintainers, I am fine with that, if this becomes more we should revisit. |
Also, there was a breaking change https://pypa-build.readthedocs.io/en/stable/changelog.html#breaking-changes. |
Resolves #214.