ValueError in versioned symbols

[reaperhulk]

When compiling a manylinux1 wheel against OpenSSL 1.1.0 the following exception is raised:

  File "/usr/local/bin/auditwheel", line 11, in <module>
    sys.exit(main())
  File "/opt/_internal/cpython-3.6.0/lib/python3.6/site-packages/auditwheel/main.py", line 49, in main
    rval = args.func(args, p)
  File "/opt/_internal/cpython-3.6.0/lib/python3.6/site-packages/auditwheel/main_repair.py", line 60, in execute
    wheel_abi = analyze_wheel_abi(args.WHEEL_FILE)
  File "/opt/_internal/cpython-3.6.0/lib/python3.6/site-packages/auditwheel/wheel_abi.py", line 82, in analyze_wheel_abi
    symbol_policy = versioned_symbols_policy(versioned_symbols)
  File "/opt/_internal/cpython-3.6.0/lib/python3.6/site-packages/auditwheel/policy/versioned_symbols.py", line 28, in versioned_symbols_policy
    sym_name, _ = symbol.split("_", 2)
ValueError: too many values to unpack (expected 2)

Looking in PDB the issue is that the symbol is expected to look something like GLIBC_2.2.5, but OpenSSL 1.1.0 is OPENSSL_1_1_0, which results in too many values.

[rmcgibbo]

Ahh, good catch. I can fix this when I'm off work, but if you'd like to file a pull request, that would be great.

[rmcgibbo]

It should be symbol.split("_", 1), I think.

[reaperhulk]

@rmcgibbo Yep PR is up :)

[njsmith]

It's not clear to me why we need to split the version strings at all, but I haven't looked at it or anything :-)

@ehashman rewrote the symbol version handling at the pycon sprints last year and might have thoughts too.

[ehashman]

I'll take a look at this.