Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for all the vendored code #126

Open
1 of 4 tasks
ehashman opened this issue Nov 13, 2018 · 0 comments
Open
1 of 4 tasks

Add tests for all the vendored code #126

ehashman opened this issue Nov 13, 2018 · 0 comments

Comments

@ehashman
Copy link
Member

ehashman commented Nov 13, 2018

As is evident in the LICENSE file, this repo consists of a lot of vendored code, particularly including the delocate stuff mentioned in #102. When we vendored the code, we probably should have also vendored the corresponding unit tests to protect us from drift...

It would be nice to go back and do that. Here's all the code we could potentially do this for that I can see. Some of these might be easy to check off if there were no upstream tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants