Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pycryptodome instead of pycrypto. #402

Closed
lalit-lintel opened this issue Apr 5, 2019 · 5 comments · Fixed by #411
Closed

Use pycryptodome instead of pycrypto. #402

lalit-lintel opened this issue Apr 5, 2019 · 5 comments · Fixed by #411

Comments

@lalit-lintel
Copy link

Versions

  • Python: 2.7.12
  • OS: Ubuntu 18.04
  • Pymodbus: 2.1.0 [twisted]
  • Modbus Hardware (if used):

Pymodbus Specific

  • Server: tcp - async

Description

I am trying to use Mod bus server on TCP protocol, but when I installed pymodbus and I saw it's installed pycrypto, which is deprecated and dead software.

I already have installed pycryptodome in my application, which is a conflict with pycrypto,
we can't have both pycrypto and pycryptodome at the same time,

Can we have pymodbus[twisted] release which can use pycryptodome instead of pycrypto?

@dhoomakethu
Copy link
Contributor

I am not sure of the amount of effort this might need, I would be glad to accept a PR if you can give a try with pycryptodome and can assure nothing breaks.

@tracernz
Copy link
Contributor

tracernz commented Apr 8, 2019

AFAICT twisted doesn't use PyCrypto? The most recent mention I can find in their repo is twisted/twisted#953

@lalit-lintel
Copy link
Author

Added pull request with changes in the setup file, which will allow installing Cryptodome instead Crypto.

Pull request #409

@github-actions
Copy link

github-actions bot commented Mar 3, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as completed Mar 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants