Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpful error messages for missing REPL imports #1832

Closed
alexrudd2 opened this issue Oct 17, 2023 · 1 comment
Closed

Add helpful error messages for missing REPL imports #1832

alexrudd2 opened this issue Oct 17, 2023 · 1 comment
Labels
Enhancements

Comments

@alexrudd2
Copy link
Collaborator 

          LGTM. Would be nice if you do REPL later.

Originally posted by @janiversen in #1831 (review)
@alexrudd2
Copy link
Collaborator Author

Upon looking at the REPL code:
(1) All of the packages imported have the same name as the import so there's no confusion (e.g. between aiohttp/web)
(2) the server and client modules are not loaded until they are used, so the ModuleNotFoundError appears at usage.

Therefore, there's no need to improve the error messages.

@alexrudd2 alexrudd2 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexrudd2