Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanity check for return_inferencedata=True #4446

Closed
wants to merge 1 commit into from
Closed

sanity check for return_inferencedata=True #4446

wants to merge 1 commit into from

Conversation

chandan5362
Copy link
Contributor

just a sanity check for return_inferencedata =True for issue #4372 .
Not ready to merge.

@michaelosthege
Copy link
Member

Many tests don't specify return_inferencedata. As a first step these tests should just use return_inferencedata=False and/or migrate to return_inferencedata=True.

@michaelosthege michaelosthege marked this pull request as draft January 29, 2021 17:00
@michaelosthege michaelosthege mentioned this pull request Jan 29, 2021
Closed
@canyon289
Copy link
Member

Any activity on this one? If not I'll close in a week or so

@michaelosthege
Copy link
Member

Any activity on this one? If not I'll close in a week or so

I think we should do a new PR for this as soon as v4 got merged.
We have a ton of deprecation warnings in the test suite about this & decided to finally flip the default with v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandan5362 @michaelosthege @canyon289