Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generalized normal distribution #5102

Closed
shifdz opened this issue Oct 26, 2021 · 5 comments
Closed

Add generalized normal distribution #5102

shifdz opened this issue Oct 26, 2021 · 5 comments

Comments

@shifdz
Copy link

shifdz commented Oct 26, 2021

Is it possible to use distributions from scipy stat or tensorflow probability in PYMC3? I need to use generalized normal distribution, but it is not avialable in PYMC3. Any help is really appreciated.

@ricardoV94
Copy link
Member

You cannot use scipy/tensorflow directly, you need a function defined in theano.

Looking at the density funcition it should be pretty straightforward to define your own: https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.gennorm.html

I will mark this issue as a feature request. In the meantime if you want to go ahead and add your own distribution for your project I suggest you open an topic in our discourse: https://discourse.pymc.io/

Someone will probably help you out there

@twiecki twiecki changed the title Using distributions from scipy stats and tensorflow probability in PYMC3 Add generalized normal distribution Oct 26, 2021
@shifdz
Copy link
Author

shifdz commented Oct 26, 2021

I am new to programming and haven't worked in Theano, so I am not sure how to define a new distribution. Can someone please help me with implementing it? I opened a topic on Discourse, but didn't get any response.

@twiecki
Copy link
Member

twiecki commented Oct 27, 2021

@shifdz There is a guide here: #4686 (comment)

@shifdz
Copy link
Author

shifdz commented Oct 27, 2021

@twiecki Will the generalized normal distribution be added in pymc3 any time soon?

@twiecki
Copy link
Member

twiecki commented Oct 28, 2021

@shifdz Whenever someone creates a pull request :) It's not that hard and we're happy to help if you want to give it a go.

@pymc-devs pymc-devs locked and limited conversation to collaborators Jan 30, 2022
@ricardoV94 ricardoV94 converted this issue into discussion #5421 Jan 30, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

3 participants