Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gp submodule #5035

Closed
michaelosthege opened this issue Sep 29, 2021 · 2 comments
Closed

Refactor gp submodule #5035

michaelosthege opened this issue Sep 29, 2021 · 2 comments
Milestone

Comments

@michaelosthege
Copy link
Member

The gp submodule was not yet refactored for v4.

Here's one low-hanging fruits to start with:

  • pymc/tests/test_gp.py::TestMarginalVsMarginalSparse::testApproximations is fixed by changing the shape of the p ndarray that's passed into model.logp(...) by slicing with [None, :].

Some tests are marked with an XFAIL about the MvNormal not being refactored yet, but meanwhile it is refactored.

Also related to #5024

@twiecki
Copy link
Member

twiecki commented Oct 2, 2021

CC @bwengals

This was referenced Oct 4, 2021
@twiecki
Copy link
Member

twiecki commented Nov 21, 2021

Fixed by #5055.

@twiecki twiecki closed this as completed Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants