You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to decide whether we want to deprecate DensityDist and if so, provide at least documentation on how to add simple logp terms to a model or how to quickly implement a custom Distribution.
If we want to refactor it, it is probably good time to get rid of the whole dictionary as observed thing and force the distribution parameters to go into the signature as normal arguments in other distributions
looks related to #4534, and I also wanted to leave a link to https://discourse.pymc.io/t/using-a-random-variable-as-observed/7184/5 so we are aware of all the (in my opinion strange and redundant) things DensityDist allows, expecially when taking a dictionary as observed (which I also think is the only Distribution that does).
As I have commented a few times and started changing in #4433, I think it's a bad idea to allow FreeRVs to be values in the dictionary passed as observed. If this is a feature that is really important to DensityDist, I would suggest doing this givens extra argument or following @ricardoV94 suggestion.
We need to decide whether we want to deprecate
DensityDist
and if so, provide at least documentation on how to add simple logp terms to a model or how to quickly implement a custom Distribution.If we want to refactor it, it is probably good time to get rid of the whole dictionary as observed thing and force the distribution parameters to go into the signature as normal arguments in other distributions
The text was updated successfully, but these errors were encountered: