-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generalized linear models #91
Comments
I want to work on this. |
There seem to be issues when trying to run the notebook. It doesn't work on v3, not sure why, I don't know how GLM module works. If someone does great, otherwise it may not be worth fixing if it's a bug, we probably can update this to use bambi directly. |
hey @KavyaJaiswal, i guess since you'll be working on outreachy, if you've left this issue i can take it up!! |
Sure, all the best!! |
@almostmeenal do you plan to start on this right away? I think the best way forward is to merge @KavyaJaiswal's PR which already covers a lot of important updates so that you can then fix the second half of the notebook. Now that Bambi 0.5 is out, once the current PR is merged most of the work will be moving from pymc3.gml module to bambi. Sounds good? |
okayy!! that sounds good, you can merge the PR and then tomorrow i'll have a look at what to do next? |
General note that while I would not consider having the notebook "broken" a blocker, it would be great to port it to bambi before 3.11.3 is released and therefore the website is updated. I can also ask bambi devs for help if this timeline is too short. cc pymc-devs/pymc#4658 |
@OriolAbril okay yes that makes sense. can you give me a deadline (for personal organization) deadlines help me avoid procrastinating, then i'll get it done!!! |
@canyon289 do you have an eta on 3.11.3? |
@OriolAbril @canyon289 does 20th june work as a deadline? |
@OriolAbril are there things left to do in this notebook? (just saw that this issue still has |
I think now it's only missing the v4 update once it's released, I see I moved the issue to "best practices" but forgot to remove the help wanted label |
I will convert this to v4 |
Half way through converting this to v4, I think we are better off deleting this notebook. See #336 (comment) |
Agree that we should remove it. |
Done. Feel free to approve here #336 |
File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/generalized_linear_models/GLM.ipynb
Reviewers:
Known changes needed
Changes listed in this section should all be done at some point in order to get this
notebook to a "Best Practices" state. However, these are probably not enough!
Make sure to thoroughly review the notebook and search for other updates.
General updates
ArviZ related
az.summary
instead ofdf.describe
Notes
Exotic dependencies
Needs statsmodels
Computing requirements
All models run in less than 1min
The text was updated successfully, but these errors were encountered: