-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more packages to the new primer #6753
Conversation
Pull Request Test Coverage Report for Build 2410153713
π - Coveralls |
@jacobtylerwalls This is running into CI time-outs. See I don't really understand as this batch of packages passed on my local branch in CI and locally. Does this pass in reasonable time for you locally? |
Make sure to try with bleeding-edge astroid, it has good nutrients :D |
Does |
Well, I'm waiting to find out. It takes a long time to lint |
I got 21m in CI here: I removed |
@DanielNoord the other thing I can think of is the message dict might be huge. Could we write the message dict and flush it as each package is linted, rather than writing it out after all packages? This will also help with debugging. |
Now that I look at that workflow again I see that we never actually go beyond
Yeah that should be do-able. I was actually planning on shutting down for the night. If you want feel free to take a stab at this or just revert this PR so |
Woo hoo! The issue with pandas is fixed at pylint-dev/astroid#1579. |
Type of Changes
Description
I'll remove the empty file when we can remove the old primer as removing now requires additional refactors.