ignore-imports option ignored

[jacobtylerwalls]

Bug description

The ignore-imports=yes option is ignored in 2.14.

Place two files that both read like this (ideally in their own dir so you can just run that dir):

import os
import sys
import argparse
import random
import math

Configuration

I reproduced in an environment without a `pylintrc`.

Command used

pylint package_name --enable=duplicate-code --ignore-imports=y

Pylint output

************* Module c
sim/c.py:1:0: W0611: Unused import os (unused-import)
sim/c.py:2:0: W0611: Unused import sys (unused-import)
sim/c.py:3:0: W0611: Unused import argparse (unused-import)
sim/c.py:4:0: W0611: Unused import random (unused-import)
sim/c.py:5:0: W0611: Unused import math (unused-import)
************* Module b
sim/b.py:1:0: W0611: Unused import os (unused-import)
sim/b.py:2:0: W0611: Unused import sys (unused-import)
sim/b.py:3:0: W0611: Unused import argparse (unused-import)
sim/b.py:4:0: W0611: Unused import random (unused-import)
sim/b.py:5:0: W0611: Unused import math (unused-import)
sim/b.py:1:0: R0801: Similar lines in 2 files
==b:[0:5]
==c:[0:5]
import os
import sys
import argparse
import random
import math (duplicate-code)

Expected behavior

Proper output in 2.12:

************* Module c
sim/c.py:1:0: W0611: Unused import os (unused-import)
sim/c.py:2:0: W0611: Unused import sys (unused-import)
sim/c.py:3:0: W0611: Unused import argparse (unused-import)
sim/c.py:4:0: W0611: Unused import random (unused-import)
sim/c.py:5:0: W0611: Unused import math (unused-import)
************* Module b
sim/b.py:1:0: W0611: Unused import os (unused-import)
sim/b.py:2:0: W0611: Unused import sys (unused-import)
sim/b.py:3:0: W0611: Unused import argparse (unused-import)
sim/b.py:4:0: W0611: Unused import random (unused-import)
sim/b.py:5:0: W0611: Unused import math (unused-import)

------------------------------------------------------------------
Your code has been rated at 0.00/10 (previous run: 0.00/10, +0.00)

Pylint version

Caused in 03cfbf3

OS / Environment

No response

Additional dependencies

No response

[Pierre-Sassoulas]

I think we put some option in the global configuration namespace but the name is now misleading and should be something like "ignore-import-for-similarity" Edit: It's not has bad as I thought we're still talking about the similarity checker here..

[DanielNoord]

I think I know what is causing this. set_option of Similar sets the options from .config to an attribute of the checker. This allows running Similar standalone as it no longer requires a linter.config object.
With optparse set_option got called all the time (which is one of the things we wanted to avoid in argparse).

However, I think we might be calling it a little too little now. I'll assign myself, although I'm not sure if I can fix this before the weekend.