Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option ignore-checks-for-mixin and deprecate ignore-mixin-members #5205

Closed
DanielNoord opened this issue Oct 25, 2021 · 1 comment · Fixed by #6173
Closed

Add new option ignore-checks-for-mixin and deprecate ignore-mixin-members #5205

DanielNoord opened this issue Oct 25, 2021 · 1 comment · Fixed by #6173
Labels
Blocked 🚧 Blocked by a particular issue Configuration Related to configuration Enhancement ✨ Improvement to a component High effort 🏋 Difficult solution or problem to solve
Milestone

Comments

@DanielNoord
Copy link
Collaborator

DanielNoord commented Oct 25, 2021

Current problem

What about removing ignore-members and adding a new option ignore-checks-for-mixin which would be a comma separated list of checks that exclude Mixin? We could add the supported checks to the description of that option.
I think I have already thought of good way to deprecate an option.

Originally posted by @DanielNoord in #5203 (comment)

The current ignore-mixin-members does not really convey what it is doing: disabling certain checks for mixin classes. Most notably not-async-context-manager refers to the option, which is not really clear from the option name.

Desired solution

We would like to deprecate the option and create a new option that contains a list of options that should be disabled for mixin classes.

However, deprecation of options is quite difficult with our current set-up and since we need to move to argparse anyway it might be better to wait for that change to be done first. This is thus blocked by our move to argparse.

Additional context

No response

@DanielNoord DanielNoord added Enhancement ✨ Improvement to a component Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling Blocked 🚧 Blocked by a particular issue High effort 🏋 Difficult solution or problem to solve Configuration Related to configuration and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Oct 25, 2021
@Pierre-Sassoulas
Copy link
Member

Blocked by #2355 / #4455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked 🚧 Blocked by a particular issue Configuration Related to configuration Enhancement ✨ Improvement to a component High effort 🏋 Difficult solution or problem to solve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants