Improve typing of builtins brain #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves 14 mypy errors
jacobtylerwalls
force-pushed
the
improve-builtins-brain-typing
branch
from
0c0d473
to
5a84c69
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
=======================================
Coverage 92.71% 92.72%
=======================================
Files 94 94
Lines 10837 10848 +11
=======================================
+ Hits 10048 10059 +11
Misses 789 789
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jacobtylerwalls
force-pushed
the
improve-builtins-brain-typing
branch
from
69fb332
to
3e39101
Compare
Pierre-Sassoulas
approved these changes
Jun 19, 2023
DanielNoord
approved these changes
Jun 20, 2023
| def _unpack_keywords(self, keywords, context: InferenceContext | None = None): | ||
| def _unpack_keywords( | ||
| self, | ||
| keywords: list[tuple[str | None, nodes.NodeNG]], |
There was a problem hiding this comment.
I feel like b72eaa7 might have typed arg incorrectly. Will investigate this myself.
There was a problem hiding this comment.
Turns out to be correct, weirdly enough..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Improve typing of this brain module.
Resolves 14 mypy errors.