Require Python 3.7.2 #1542
Require Python 3.7.2 #1542
Conversation
jacobtylerwalls
added
the
Maintenance
Pull Request Test Coverage Report for Build 2301412160
💛 - Coveralls |
|
I think we should block this until pylint 2.14 has been released. We might need to do a patch release for 2.13 still. |
There was a problem hiding this comment.
I spotted one if sys.version_info >= (3, 6, 2): in astroid/nodes/scoped_nodes/scoped_nodes.py.
There is also a match for 36 in the tox.ini file which can be removed.
Grepping for minver="3.7 will also show a couple @test_utils.require_version( decorators in tests that can be removed. Note that there also minver="3.7.2" matches.
Rest LGTM 😄
|
The issue with python 3.11 come from main. I think it would be reasonable to temporarily skip this test for python 3.11, because the alternative seems to be making astroid understand the 3.11 code. |
There was a problem hiding this comment.
Looks good!
Regarding the 3.11 test failure: Tbh I'm not really sure what the issue is. I believe it appeared just recently (maybe with 3.11.0b1) but when testing that version locally, everything works fine. Maybe it's a linux and / or Github actions specific thing. (Only tested MacOS.)
Description
Require Python 3.7.2 to run
astroid. Partner to pylint-dev/pylint#5921.One benefit of dropping 3.6 is to reduce risk from proposed performance-enhancing changes in #1536, where according to the complicated history of python/cpython#5481 and its (initial?) reversion on 3.6, it is possible that the behavior might vary there.
Type of Changes