PEP 484 type comments for vararg and kwarg?

[tjprescott]

It seems like the Arguments class only has annotations for kwarg and vararg, and does not have any property for getting the type comment.

Per PEP484, this should be supported (https://peps.python.org/pep-0484/#suggested-syntax-for-python-2-7-and-straddling-code)

def embezzle(self, account, funds=1000000, *fake_receipts):
    # type: (str, int, *str) -> None
    """Embezzle funds from account using fake receipts."""
    <code goes here>

How would I obtain the type comment for *fake_receipts?

[AWhetter]

For what you want, you access it through type_comment_args.

>>> import astroid
>>> code = """def embezzle(self, account, funds=1000000, *fake_receipts):
...     # type: (str, int, *str) -> None
...     pass
... """
>>> func = astroid.extract_node(code)
>>> func.type_comment_args
[<Name.str l.1 at 0x7fcaf0084c40>, <Name.int l.1 at 0x7fcaf0084f40>, <Name.str l.1 at 0x7fcaf0084e50>]
>>> func.type_comment_args[2]
<Name.str l.1 at 0x7fcaf0084e50>

What isn't possible though is splitting up the arguments, type commenting each, and getting the annotation that way.

def embezzle(
     self,
     account,  # type: str
     funds=1000000,   # type: int
     *fake_receipts,  # type: str
 ):
     # type: (...) -> None
     pass

In that case there's no way to get the type comment. It looks like this was missing from the original representation. We should add both a type_comment_vararg: Optional[NodeNG] field and a type_comment_kwarg: Optional[NodeNG] field to the Arguments node.

[tjprescott]

Thank you for the workaround! I agree that type_comment_vararg and type_commend_kwarg route would be the best (most consistent) path forward.

[tjprescott]

Also, it seems like this only works for *args and not **kwargs.

    def with_variadic_typehint(
        self,
        *vars, # type: str
        **kwargs # type: Any
    ):
        # type: (*str, **Any) -> None
        pass

[<AssignName.self l.2 at 0x1e658b71240>]

And **kwargs doesn't appear in the kwonlyargs either.