Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider conforming to PEP 561 in order to make type annotations usable #123

Open
alehed opened this issue Sep 18, 2023 · 0 comments
Open

Comments

@alehed
Copy link

alehed commented Sep 18, 2023

Without this, the type annotations are not that useful when using mypy, as mypy will consider the package untyped and ignore the type annotations.

Conforming to PEP 561 entails:

  • moving from a single-file package to a folder with an __init__.py that exports the same interface as the file.
  • adding a py.typed file to the folder (and adding include = ["minimalmodbus/py.typed"] to the pyproject.toml)

If you would like me to make a PR with those changes, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant