Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events as types in python #3121

Open
wants to merge 52 commits into
base: main
Choose a base branch
from

Conversation

gresm
Copy link
Contributor

@gresm gresm commented Sep 25, 2024

Redo of #2866, but as requested here: #2866 (review) in python.

This is the third and hopefully last pull request from the chain of: #3000 and #3045, this patch by itself isn't very large, but it relies on the work of these pull requests, so it might be easier reviewing them one by one.

Closes #2759

gresm added 30 commits June 17, 2024 19:58
@gresm gresm requested a review from a team as a code owner September 25, 2024 18:17
@gresm gresm force-pushed the events-as-types-python branch 2 times, most recently from 8106316 to 2ba6cef Compare September 25, 2024 19:01
@gresm gresm force-pushed the events-as-types-python branch from 2ba6cef to 537c527 Compare September 25, 2024 19:03
@gresm gresm mentioned this pull request Sep 25, 2024
4 tasks
@yunline yunline added enhancement event pygame.event labels Sep 26, 2024
@gresm gresm force-pushed the events-as-types-python branch from 112e765 to 537c527 Compare October 22, 2024 19:38
@gresm
Copy link
Contributor Author

gresm commented Oct 22, 2024

Per #3122 (comment), the pygame.event.peek(None) was removed, even though this PR seems to fix the crash.

@gresm gresm force-pushed the events-as-types-python branch from 5dfe6b1 to ea8e2b6 Compare October 22, 2024 20:26
@gresm gresm force-pushed the events-as-types-python branch from 909d7b4 to e86d6de Compare December 14, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: event types are actual types
2 participants